Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tests): Fixes a couple of tests, plus small tweaks #1664

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

KevSanchez
Copy link
Collaborator

Fixes a few non-passing tests due to previous changes, plus small tweaks/notes

Overview

Please write a description. If the PR is hard to understand, provide a quick explanation of the code.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.

Feature relevant tickets

Link to the related task manager tickets


Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

@KevSanchez KevSanchez requested a review from hotzevzl March 12, 2024 15:48
Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marxan ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 4:01pm

Copy link
Member

@hotzevzl hotzevzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks! I had missed the fundamental createWorld() step where PU locks were set still without the flag to mark them as set by the user 🤦🏼

@hotzevzl hotzevzl merged commit d211c47 into develop Mar 13, 2024
61 checks passed
@hotzevzl hotzevzl deleted the fix/api/small-assorted-fixes branch March 13, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants